Bug 261986 - [CSS-Sizing] Block size with max-content and min-content in a table
Summary: [CSS-Sizing] Block size with max-content and min-content in a table
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks: 265626
  Show dependency treegraph
 
Reported: 2023-09-22 17:58 PDT by Ahmad Saleem
Modified: 2023-11-30 18:18 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-09-22 17:58:49 PDT
Hi Team,

While going through Blink's commit, I came across fix for two failing WPT in CSS-Sizing:

Link: http://wpt.live/css/css-sizing/block-size-with-min-or-max-content-table-1b.html & http://wpt.live/css/css-sizing/block-size-with-min-or-max-content-table-1a.html

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/3a0c4adda19bade345ca115fdcfe825acf0b8869

^ Only doing partial merge of 'RenderTable.cpp', make us pass above two tests in my local build.

Line 532:

if (logicalMaxHeightLength.isFillAvailable() || (logicalMaxHeightLength.isSpecified() && !logicalMaxHeightLength.isNegative() && !logicalMaxHeightLength.isMinContent() && !logicalMaxHeightLength.isMaxContent() && !logicalMaxHeightLength.isFitContent()))

Line 538 (new to add):

if (logicalMinHeightLength.isMinContent() || logicalMinHeightLength.isMaxContent() || logicalMinHeightLength.isFitContent())
            logicalMinHeightLength = LengthType::Auto;

___

I have this patch in local since long and haven't had any issue.

Just raising so I can fix it later. Adding 'BrowserCompat' since only Safari / WebKit is failing these tests and 'WPTImpact' tag due to tests being on WPT.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-09-29 17:59:22 PDT
<rdar://problem/116264670>
Comment 2 Ahmad Saleem 2023-10-29 17:48:28 PDT
Second PR Attempt (with now wpt test import) - https://github.com/WebKit/WebKit/pull/19699

Thanks to Tim. :-)
Comment 3 EWS 2023-11-22 07:12:51 PST
Committed 271054@main (e180ca76e7e0): <https://commits.webkit.org/271054@main>

Reviewed commits have been landed. Closing PR #19699 and removing active labels.