Bug 262016 - REGRESSION(268368@main): causes an assertion failure for http tests
Summary: REGRESSION(268368@main): causes an assertion failure for http tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 261671
  Show dependency treegraph
 
Reported: 2023-09-24 13:43 PDT by WebKit Commit Bot
Modified: 2023-09-24 16:21 PDT (History)
4 users (show)

See Also:


Attachments
REVERT of 268368@main (397.73 KB, patch)
2023-09-24 13:43 PDT, WebKit Commit Bot
Hironori.Fujii: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2023-09-24 13:43:07 PDT
https://commits.webkit.org/268368@main introduced a regression:
causes an assertion failure for http tests

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2023-09-24 13:43:14 PDT
Created attachment 467843 [details]
REVERT of 268368@main

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Fujii Hironori 2023-09-24 13:54:24 PDT
Oh, no.

> error: patch failed: LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/newlines.vtt:1
> error: LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/newlines.vtt: patch does not apply
Comment 3 Fujii Hironori 2023-09-24 14:08:10 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18135
Comment 4 Kueno 2023-09-24 15:55:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18139
Comment 5 EWS 2023-09-24 16:20:27 PDT
Committed 268377@main (aa8ce99efeea): <https://commits.webkit.org/268377@main>

Reviewed commits have been landed. Closing PR #18135 and removing active labels.
Comment 6 Radar WebKit Bug Importer 2023-09-24 16:21:14 PDT
<rdar://problem/115966306>