RESOLVED FIXED262033
Partial Sync 'CSSRule.idl' and 'CSSStyleRule.idl' to Web Specification 
https://bugs.webkit.org/show_bug.cgi?id=262033
Summary Partial Sync 'CSSRule.idl' and 'CSSStyleRule.idl' to Web Specification
Ahmad Saleem
Reported 2023-09-25 05:07:05 PDT
Hi Team, While going through one of test case from Blink, I came across that we are failing one test case. Test Case: css-element-attribute-js-null.html (Blink copy - does not run as JSFiddle) ___ Web-Spec: https://drafts.csswg.org/cssom/#the-cssrule-interface We need to change from: attribute DOMString? cssText; to attribute DOMString cssText; >> Remove '?' ___ Web-Spec: https://drafts.csswg.org/cssom/#the-cssstylerule-interface We need to change from: attribute DOMString? selectorText; to attribute DOMString selectorText; >> Remove '?' ____ Ideally, we should use 'CSSOMString' but it leads to issue so I think for temporary, this partial sync is better and make us match Chrome, which was trying to match Firefox. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2023-09-25 05:09:18 PDT
Sync test changes from here - https://src.chromium.org/viewvc/blink?revision=163424&view=revision Because upstream blink test case has changes for 'CSSPageRule', which is more involved and requires C++ changes as well (have it locally compiled and working as well). But just wanted to do it separately. So raised this as simple one and then can do later for more involved one separately.
Anne van Kesteren
Comment 2 2023-09-25 05:49:51 PDT
I'm not sure CSSOMString is needed. It ends up meaning either DOMString or USVString and changing it all to USVString is prolly a performance hit. Would need some careful investigation.
Radar WebKit Bug Importer
Comment 3 2023-10-02 05:08:24 PDT
<rdar://problem/116340666>
EWS
Comment 4 2023-10-03 09:13:52 PDT
Committed 268783@main (a8eba40b3bd4): <https://commits.webkit.org/268783@main> Reviewed commits have been landed. Closing PR #18549 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.