NEW262152
REGRESSION(267579@main): [ Debug ] ASSERTION FAILED: !m_pendingNavigationID causing 5 tests under TestWebKitAPI.WKBackForwardList to constantly timeout. 
https://bugs.webkit.org/show_bug.cgi?id=262152
Summary REGRESSION(267579@main): [ Debug ] ASSERTION FAILED: !m_pendingNavigationID c...
Ben Schwartz
Reported 2023-09-26 16:58:07 PDT
The following tests are constantly timing out on debug builds: TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsFromLoadRequest TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithRecentUserGestureFragment TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithRecentUserGesturePushState TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithUserGestureFragment TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithUserGesturePushState HISTORY: https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsFromLoadRequest&test=TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithRecentUserGestureFragment&test=TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithRecentUserGesturePushState&test=TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithUserGestureFragment&test=TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithUserGesturePushState&style=debug STDIO LOG: TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithUserGesturePushState ASSERTION FAILED: !m_pendingNavigationID /Volumes/Data/worker/Apple-Ventura-Debug-Build/build/Source/WebKit/WebProcess/WebPage/WebPage.cpp(2145) : void WebKit::WebPage::goToBackForwardItem(WebKit::GoToBackForwardItemParameters &&) 1 0x107a57e28 WTFCrash 2 0x131ceabf0 std::__1::span<unsigned char const, 18446744073709551615ul>::span[abi:v15006]<unsigned char const*>(unsigned char const*, unsigned long) 3 0x134706af0 WebKit::WebPage::goToBackForwardItem(WebKit::GoToBackForwardItemParameters&&) 4 0x1347cc1f0 auto void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WebKit::GoToBackForwardItemParameters&&), std::__1::tuple<WebKit::GoToBackForwardItemParameters>>(WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::GoToBackForwardItemParameters&&), std::__1::tuple<WebKit::GoToBackForwardItemParameters>&&)::'lambda'(auto&&...)::operator()<WebKit::GoToBackForwardItemParameters>(auto&&...) const 5 0x1347cc144 decltype(std::declval<WebKit::WebPage>()(std::declval<WebKit::GoToBackForwardItemParameters>())) std::__1::__invoke[abi:v15006]<void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WebKit::GoToBackForwardItemParameters&&), std::__1::tuple<WebKit::GoToBackForwardItemParameters>>(WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::GoToBackForwardItemParameters&&), std::__1::tuple<WebKit::GoToBackForwardItemParameters>&&)::'lambda'(auto&&...), WebKit::GoToBackForwardItemParameters>(WebKit::WebPage&&, WebKit::GoToBackForwardItemParameters&&) 6 0x1347cc118 decltype(auto) std::__1::__apply_tuple_impl[abi:v15006]<void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WebKit::GoToBackForwardItemParameters&&), std::__1::tuple<WebKit::GoToBackForwardItemParameters>>(WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::GoToBackForwardItemParameters&&), std::__1::tuple<WebKit::GoToBackForwardItemParameters>&&)::'lambda'(auto&&...), std::__1::tuple<WebKit::GoToBackForwardItemParameters>, 0ul>(WebKit::WebPage&&, WebKit::WebPage&&, std::__1::__tuple_indices<0ul>) 7 0x1347cc0dc decltype(auto) std::__1::apply[abi:v15006]<void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WebKit::GoToBackForwardItemParameters&&), std::__1::tuple<WebKit::GoToBackForwardItemParameters>>(WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::GoToBackForwardItemParameters&&), std::__1::tuple<WebKit::GoToBackForwardItemParameters>&&)::'lambda'(auto&&...), std::__1::tuple<WebKit::GoToBackForwardItemParameters>>(WebKit::WebPage&&, WebKit::WebPage&&) 8 0x1347cad4c void IPC::callMemberFunction<WebKit::WebPage, WebKit::WebPage, void (WebKit::GoToBackForwardItemParameters&&), std::__1::tuple<WebKit::GoToBackForwardItemParameters>>(WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::GoToBackForwardItemParameters&&), std::__1::tuple<WebKit::GoToBackForwardItemParameters>&&) 9 0x13478605c void IPC::handleMessage<Messages::WebPage::GoToBackForwardItem, WebKit::WebPage, WebKit::WebPage, void (WebKit::GoToBackForwardItemParameters&&)>(IPC::Connection&, IPC::Decoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::GoToBackForwardItemParameters&&)) 10 0x13477d800 WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::Decoder&) 11 0x1347167e0 WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 12 0x134c8e380 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 13 0x133d1362c WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 14 0x134c646f4 IPC::Connection::dispatchMessage(IPC::Decoder&) 15 0x134c64b24 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder>>) 16 0x134c64e34 IPC::Connection::dispatchOneIncomingMessage() 17 0x134c81de0 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder>>)::$_17::operator()() const 18 0x134c81d3c WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder>>)::$_17, void>::call() 19 0x107a802f4 WTF::Function<void ()>::operator()() const 20 0x107b15a88 WTF::RunLoop::performWork() 21 0x107b19f88 WTF::RunLoop::performWork(void*) 22 0x18318663c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 23 0x1831865d0 __CFRunLoopDoSource0 24 0x183186340 __CFRunLoopDoSources0 25 0x183184f48 __CFRunLoopRun 26 0x1831844b8 CFRunLoopRunSpecific 27 0x1840fdfbc -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 28 0x184176cbc -[NSRunLoop(NSRunLoop) run] 29 0x182df6594 _xpc_objc_main 30 0x182df5eb4 xpc_main 31 0x132b1aaf4 WebKit::XPCServiceMain(int, char const**) REPRODUCIBILITY: I was able to reproduce this issue on macOS Ventura (13.5, 22G74/arm64) ToT as a flaky timeout using the following command: run-api-tests --no-build --debug --verbose --force --iterations 50 --child-processes 5 TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsFromLoadRequest TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithRecentUserGestureFragment TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithRecentUserGesturePushState TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithUserGestureFragment TestWebKitAPI.WKBackForwardList.BackForwardNavigationDoesNotSkipItemsWithUserGesturePushState REGRESSION: I was able to identify a potential regression point at 267579@main. This issue did not reproduce before then, and changes at that point appear to be directly related to the issue.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-09-26 16:58:19 PDT
<rdar://problem/116090758>
EWS
Comment 2 2023-09-26 17:24:14 PDT
Test gardening commit 268489@main (9b04768cc482): <https://commits.webkit.org/268489@main> Reviewed commits have been landed. Closing PR #18255 and removing active labels.
Alexey Proskuryakov
Comment 3 2023-09-27 18:26:27 PDT
This is still happening after the fix in bug 261837, which was correcting the same assertion failure introduced in 267579@main as well.
EWS
Comment 4 2023-09-27 20:51:45 PDT
Test gardening commit 268560@main (50af8e921533): <https://commits.webkit.org/268560@main> Reviewed commits have been landed. Closing PR #18327 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.