Bug 262164 - [commits.webkit.org] Ignore requests for invalid refs
Summary: [commits.webkit.org] Ignore requests for invalid refs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-26 21:09 PDT by Jonathan Bedard
Modified: 2023-09-27 10:59 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-09-26 21:09:03 PDT 
There is a relatively narrow set of valid references commits.webkit.org will be able to resolve to actual commits. Although we can always check a reference against commits.webkit.org's checkout, that's relatively expensive. We should just early exit if a requested ref is an obviously invalid string.
Comment 1 Radar WebKit Bug Importer 2023-09-26 21:09:40 PDT 
<rdar://problem/116099852>
Comment 2 Jonathan Bedard 2023-09-27 10:45:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18291
Comment 3 EWS 2023-09-27 10:59:49 PDT 
Committed 268522@main (0441827bd96f): <https://commits.webkit.org/268522@main>

Reviewed commits have been landed. Closing PR #18291 and removing active labels.