Bug 262166 - [Win] Ninja clang-cl and MSBuild clang-cl should use the same compiler warning flags
Summary: [Win] Ninja clang-cl and MSBuild clang-cl should use the same compiler warnin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-26 23:38 PDT by Fujii Hironori
Modified: 2023-09-27 00:49 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2023-09-26 23:38:49 PDT 
[Win] Ninja clang-cl and MSBuild clang-cl should use the same compiler warning flags

CMake Visual Studio generator ignores some MSVC-style compiler
warning flags, for example /wd4100, for clang-cl, while CMake Ninja generator doesn't.
They should match.
Comment 1 Fujii Hironori 2023-09-26 23:49:23 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18264
Comment 2 EWS 2023-09-27 00:49:17 PDT 
Committed 268497@main (0c72c18c1345): <https://commits.webkit.org/268497@main>

Reviewed commits have been landed. Closing PR #18264 and removing active labels.