Bug 262226 - Remove RefPtr::releaseConstNonNull
Summary: Remove RefPtr::releaseConstNonNull
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Reno
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-27 15:59 PDT by Ryan Reno
Modified: 2023-09-27 19:34 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Reno 2023-09-27 15:59:42 PDT 
There are no users of releaseConstNonNull. We can use Ref's templated move ctor to move from releaseNonNull's Ref<T> to Ref<const T> which is how Ref<const T> are being constructed from RefPtrs now (see FetchBody::extract)
Comment 1 Radar WebKit Bug Importer 2023-09-27 16:00:10 PDT 
<rdar://problem/116146895>
Comment 2 Ryan Reno 2023-09-27 16:15:08 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18314
Comment 3 EWS 2023-09-27 19:34:57 PDT 
Committed 268558@main (b08052889f6e): <https://commits.webkit.org/268558@main>

Reviewed commits have been landed. Closing PR #18314 and removing active labels.