Bug 262227 - REGRESSION (268472@main): [ macOS wk2 ] Three test failures due to url failed
Summary: REGRESSION (268472@main): [ macOS wk2 ] Three test failures due to url failed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
: 262216 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-09-27 16:12 PDT by Karl Rackler
Modified: 2023-09-27 18:21 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Rackler 2023-09-27 16:12:16 PDT
Description:
http/tests/contentextensions/block-everything-unless-domain-iframe.html
http/tests/contentextensions/block-everything-unless-domain-redirect.py
http/tests/contentextensions/main-resource-redirect-error.html

Are a consistent/flaky failure on macOS ToT and since 268472@main.
One test is consistently failing and the other two tests are flaky failing on macOS wk2.

This looks to be more of a progression in reporting if url failed due to change in <https://commits.webkit.org/268472@main>.

This issue can be bisected to 268472@main using command:
run-webkit-tests --release --iterations=1 http/tests/contentextensions/block-everything-unless-domain-iframe.html

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Fcontentextensions%2Fblock-everything-unless-domain-iframe.html&test=http%2Ftests%2Fcontentextensions%2Fblock-everything-unless-domain-redirect.py&test=http%2Ftests%2Fcontentextensions%2Fmain-resource-redirect-error.html&platform=mac

Diff:
--- /Volumes/Data/worker/Apple-Ventura-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/contentextensions/main-resource-redirect-error-expected.txt
+++ /Volumes/Data/worker/Apple-Ventura-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/contentextensions/main-resource-redirect-error-actual.txt
@@ -1,3 +1,4 @@
+Failed: The URL was blocked by a content blocker (errorDomain=WebKitErrorDomain, code=104) for URL http://127.0.0.1:8000/contentextensions/main-resource-redirect-blocked.py
 main frame - didFinishDocumentLoadForFrame
 main frame - didHandleOnloadEventsForFrame
 main frame - didFinishLoadForFrame

--- /Volumes/Data/worker/Apple-Ventura-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/contentextensions/block-everything-unless-domain-redirect-expected.txt
+++ /Volumes/Data/worker/Apple-Ventura-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/contentextensions/block-everything-unless-domain-redirect-actual.txt
@@ -1,3 +1,4 @@
+Failed: The URL was blocked by a content blocker (errorDomain=WebKitErrorDomain, code=104) for URL http://127.0.0.1:8000/contentextensions/block-everything-unless-domain-redirect.py
 CONSOLE MESSAGE: Content blocker prevented frame displaying http://localhost/contentextensions/resources/should-not-load.html from loading a resource from http://localhost/contentextensions/resources/should-not-load.html
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600

--- /Volumes/Data/worker/Apple-Ventura-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/contentextensions/block-everything-unless-domain-iframe-expected.txt
+++ /Volumes/Data/worker/Apple-Ventura-Release-AppleSilicon-WK2-Tests/build/layout-test-results/http/tests/contentextensions/block-everything-unless-domain-iframe-actual.txt
@@ -1,3 +1,4 @@
+Failed: The URL was blocked by a content blocker (errorDomain=WebKitErrorDomain, code=104) for URL http://127.0.0.1:8000/contentextensions/block-everything-if-domain.html
 CONSOLE MESSAGE: The page loaded successfully.
 CONSOLE MESSAGE: This page should load.
Comment 1 Radar WebKit Bug Importer 2023-09-27 16:13:03 PDT
<rdar://problem/116147472>
Comment 2 Karl Rackler 2023-09-27 17:25:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18317
Comment 3 EWS 2023-09-27 17:32:47 PDT
Committed 268551@main (200efb15d9bd): <https://commits.webkit.org/268551@main>

Reviewed commits have been landed. Closing PR #18317 and removing active labels.
Comment 4 Fujii Hironori 2023-09-27 17:42:03 PDT
*** Bug 262216 has been marked as a duplicate of this bug. ***
Comment 5 Fujii Hironori 2023-09-27 17:53:13 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/18320
Comment 6 EWS 2023-09-27 17:57:19 PDT
Committed 268554@main (acb83c08ddc2): <https://commits.webkit.org/268554@main>

Reviewed commits have been landed. Closing PR #18320 and removing active labels.
Comment 7 WebKit Commit Bot 2023-09-27 18:08:29 PDT
Re-opened since this is blocked by bug 262232
Comment 8 Sam Sneddon [:gsnedders] 2023-09-27 18:21:42 PDT
sorry for the noise, needing something to try to revert