Bug 262231 - Have NativePromise takes an optional LogSiteIdentifier
Summary: Have NativePromise takes an optional LogSiteIdentifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-27 17:49 PDT by Jean-Yves Avenard [:jya]
Modified: 2023-10-16 16:54 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-09-27 17:49:32 PDT 
As discussed on slack, having to pass a const char* at all calling point makes for cumbersome syntax.

Passing an optional LogSiteIdentifier would make things neater and more practical.
Comment 1 Radar WebKit Bug Importer 2023-09-27 17:49:48 PDT 
<rdar://problem/116151538>
Comment 2 Jean-Yves Avenard [:jya] 2023-09-28 05:00:41 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18340
Comment 3 EWS 2023-09-29 23:06:53 PDT 
Committed 268692@main (1001da37687a): <https://commits.webkit.org/268692@main>

Reviewed commits have been landed. Closing PR #18340 and removing active labels.