Bug 262410 - [IFC][Cleanup] InlineFormattingContext should construct/own InlineLayoutState
Summary: [IFC][Cleanup] InlineFormattingContext should construct/own InlineLayoutState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-09-29 15:52 PDT by zalan
Modified: 2023-10-01 09:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (43.52 KB, patch)
2023-09-29 16:10 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (43.67 KB, patch)
2023-09-29 18:19 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (43.70 KB, patch)
2023-09-29 18:56 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (46.57 KB, patch)
2023-10-01 08:15 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-09-29 15:52:55 PDT 
ssia
Comment 1 zalan 2023-09-29 16:10:15 PDT 
Created attachment 467981 [details]
Patch
Comment 2 zalan 2023-09-29 18:19:54 PDT 
Created attachment 467986 [details]
Patch
Comment 3 zalan 2023-09-29 18:56:05 PDT 
Created attachment 467987 [details]
Patch
Comment 4 Antti Koivisto 2023-10-01 03:57:54 PDT 
Comment on attachment 467987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467987&action=review

nice!

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:771
> +    if (auto adjustedRect = InlineFormattingQuirks::adjustedRectForLineGridLineAlign(constraints.logicalRect, formattingContext().root().style(), inlineLayoutState()))
>          constraints.logicalRect = *adjustedRect;

adjustedRectForLineGridLineAlign can now be turned non-static and called via formattingContext().formattingQuirks(). Then it will only need the constraints.logicalRect parameter.
Comment 5 zalan 2023-10-01 06:50:22 PDT 
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 467987 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467987&action=review
> 
> nice!
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:771
> > +    if (auto adjustedRect = InlineFormattingQuirks::adjustedRectForLineGridLineAlign(constraints.logicalRect, formattingContext().root().style(), inlineLayoutState()))
> >          constraints.logicalRect = *adjustedRect;
> 
> adjustedRectForLineGridLineAlign can now be turned non-static and called via
> formattingContext().formattingQuirks(). Then it will only need the
> constraints.logicalRect parameter.
good point!
Comment 6 zalan 2023-10-01 08:15:46 PDT 
Created attachment 468003 [details]
[fast-cq]Patch
Comment 7 EWS 2023-10-01 09:55:50 PDT 
Committed 268703@main (8ac5e0757320): <https://commits.webkit.org/268703@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468003 [details].
Comment 8 Radar WebKit Bug Importer 2023-10-01 09:56:13 PDT 
<rdar://problem/116314369>