Bug 262472 - [Curl] Reduce unnecessary data conversions
Summary: [Curl] Reduce unnecessary data conversions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-01 23:36 PDT by Kenji Shukuwa
Modified: 2023-10-03 13:19 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenji Shukuwa 2023-10-01 23:36:22 PDT 
Currently, a SharedBuffer is generated in CurlRequest::didReceiveDataCallback when receiving data
from libcurl. However, if CurlRequest::didReceiveData performs CURL_WRITEFUNC_PAUSE processing,
this SharedBuffer will be discarded without being used.

Also, CurlMultipartHandle::didReceiveMessage performs a SharedBuffer to Vector conversion.
This is a wasteful data conversion.

For this reason, avoid converting to SharedBuffer at the time of CurlRequest::didReceiveDataCallback.
Comment 1 Kenji Shukuwa 2023-10-01 23:58:49 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18486
Comment 2 EWS 2023-10-03 13:18:03 PDT 
Committed 268801@main (7ab6aab9c1b7): <https://commits.webkit.org/268801@main>

Reviewed commits have been landed. Closing PR #18486 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-10-03 13:19:16 PDT 
<rdar://problem/116418404>