Bug 262496 - Extensions CodeGenerator needs to handle objects better
Summary: Extensions CodeGenerator needs to handle objects better
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Extensions (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-02 12:12 PDT by Timothy Hatcher
Modified: 2023-10-02 14:14 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2023-10-02 12:12:44 PDT 
Right now the object checks can try to aggressively convert many things to an NSDictionary, when only basic Object should be converted, and everything else should be JSValue.
Comment 1 Radar WebKit Bug Importer 2023-10-02 12:12:53 PDT 
<rdar://problem/116359645>
Comment 2 Timothy Hatcher 2023-10-02 12:27:18 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18506
Comment 3 EWS 2023-10-02 14:14:51 PDT 
Committed 268747@main (60e0f080e0bd): <https://commits.webkit.org/268747@main>

Reviewed commits have been landed. Closing PR #18506 and removing active labels.