Bug 262504 - [git-webkit] Rely on cache when identifier and branch specified
Summary: [git-webkit] Rely on cache when identifier and branch specified
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-02 14:16 PDT by Jonathan Bedard
Modified: 2023-10-02 14:54 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-10-02 14:16:23 PDT 
When defining a commit, clients may specify both an identifier and a branch to the Git object's commit function. In the event the identifier they specify is an integer (instead of the traditional '###.###@<branch>' string) and the branch specified via the 'branch' argument, we don't consult the cache. Notably, this is the way that the 'find' function will pass arguments to 'commit'. We should consult the cache in this circumstance.
Comment 1 Radar WebKit Bug Importer 2023-10-02 14:16:38 PDT 
<rdar://problem/116366226>
Comment 2 Jonathan Bedard 2023-10-02 14:32:51 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18511
Comment 3 EWS 2023-10-02 14:54:58 PDT 
Committed 268750@main (6a5dbe08f760): <https://commits.webkit.org/268750@main>

Reviewed commits have been landed. Closing PR #18511 and removing active labels.