Bug 262535 - [WebTransport] Fix build of trimToValidUTF8Length1024() with -Wreturn-std-move
Summary: [WebTransport] Fix build of trimToValidUTF8Length1024() with -Wreturn-std-move
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-03 05:08 PDT by Olivier Blin
Modified: 2023-10-04 17:57 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Blin 2023-10-03 05:08:06 PDT 
The following errors occurred in a developer build:


/app/webkit/Source/WebCore/Modules/webtransport/WebTransport.cpp:215:16: error: local variable 'string' will be copied despite being returned by name [-Werror,-Wreturn-std-move]
        return string;
               ^~~~~~
/app/webkit/Source/WebCore/Modules/webtransport/WebTransport.cpp:215:16: note: call 'std::move' explicitly to avoid copying
        return string;
               ^~~~~~
               std::move(string)
/app/webkit/Source/WebCore/Modules/webtransport/WebTransport.cpp:219:20: error: local variable 'string' will be copied despite being returned by name [-Werror,-Wreturn-std-move]
            return string;
                   ^~~~~~
/app/webkit/Source/WebCore/Modules/webtransport/WebTransport.cpp:219:20: note: call 'std::move' explicitly to avoid copying
            return string;
                   ^~~~~~
                   std::move(string)
/app/webkit/Source/WebCore/Modules/webtransport/WebTransport.cpp:224:20: error: local variable 'string' will be copied despite being returned by name [-Werror,-Wreturn-std-move]
            return string;
                   ^~~~~~
/app/webkit/Source/WebCore/Modules/webtransport/WebTransport.cpp:224:20: note: call 'std::move' explicitly to avoid copying
            return string;
                   ^~~~~~
                   std::move(string)
Comment 1 Olivier Blin 2023-10-03 05:19:00 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18547
Comment 2 EWS 2023-10-04 17:55:59 PDT 
Committed 268885@main (09d53ca80dff): <https://commits.webkit.org/268885@main>

Reviewed commits have been landed. Closing PR #18547 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-10-04 17:57:22 PDT 
<rdar://problem/116496021>