Bug 262585 - ScrollView::convertChildToSelf / convertSelfToChild fail to take top content inset into account
Summary: ScrollView::convertChildToSelf / convertSelfToChild fail to take top content ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 16
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-03 16:05 PDT by Simon Fraser (smfr)
Modified: 2023-10-05 14:11 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2023-10-03 16:05:11 PDT 
ScrollView::convertChildToSelf() and convertSelfToChild() offset the point by the scroll position, but this fails to take top content inset, and left-side scrollbars into account.

This code path isn't hit in general browsing, but future PDF plugin code needs it to work.
Comment 1 Radar WebKit Bug Importer 2023-10-03 16:05:28 PDT 
<rdar://problem/116430905>
Comment 2 Simon Fraser (smfr) 2023-10-03 16:22:20 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18594
Comment 3 EWS 2023-10-05 14:11:40 PDT 
Committed 268942@main (7b193c245074): <https://commits.webkit.org/268942@main>

Reviewed commits have been landed. Closing PR #18594 and removing active labels.