Bug 262620 - [Potential Optimization] Do less integer division on ARM since it is slow
Summary: [Potential Optimization] Do less integer division on ARM since it is slow
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-04 08:41 PDT by Ahmad Saleem
Modified: 2023-10-06 07:41 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-10-04 08:41:07 PDT 
Hi Team,

This is potential optimization, which might be applicable in WebKit code but couldn't at the same team or not worthwhile due to code complexity.

Although I thought to raise bug to get input.

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=171031

WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/GlyphPage.h#78 & https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/Font.cpp#414

Just wanted to raise. CCing - Chris - who might be interested to share his input.

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-10-04 13:23:24 PDT 
<rdar://problem/116482301>
Comment 2 Vitor Roriz 2023-10-04 13:41:20 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18638
Comment 3 Vitor Roriz 2023-10-06 07:24:38 PDT 
Thank you for the report Ahmad, however, I've tested the performance for these changes and they didn't show any relevant progression on our ARM-based devices. Probably nowadays the compilers are smart enough to optimize it.