Bug 262839 - HAVE_SAFARI_SERVICES_FRAMEWORK should be renamed to USE_SAFARI_SERVICES_FRAMEWORK
Summary: HAVE_SAFARI_SERVICES_FRAMEWORK should be renamed to USE_SAFARI_SERVICES_FRAME...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-07 07:39 PDT by Matthew Benedict
Modified: 2023-10-14 07:40 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Benedict 2023-10-07 07:39:46 PDT 
There's already a FIXME for this issue in the code (https://github.com/WebKit/WebKit/blob/5870261ff9b3f700cae3614190213e0dc5f0477c/Source/WTF/wtf/PlatformHave.h#L439) but I was unable to find a Bugzilla issue for this.

The name of HAVE_SAFARI_SERVICES_FRAMEWORK implies it does not exist in macOS, but WebKit is simply not using it, so it would make more sense as USE_SAFARI_SERVICES_FRAMEWORK.
Comment 1 Radar WebKit Bug Importer 2023-10-14 07:40:15 PDT 
<rdar://problem/116958630>