262866 – text-decoration-thickness should support percentages

Bug 262866 - text-decoration-thickness should support percentages

Summary: text-decoration-thickness should support percentages

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	CSS (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	ChangSeok Oh

URL:
Keywords:	GoodFirstBug, InRadar

Duplicates (1):	255868 (view as bug list)
Depends on:
Blocks:

Reported:	2023-10-08 10:35 PDT by Tim Nguyen (:ntim)
Modified:	2023-10-28 04:16 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tim Nguyen (:ntim) 2023-10-08 10:35:41 PDT

This should be pretty simple to support given we already support ems.

Here are places that need changing:

https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/css/CSSProperties.json#8301-8305

https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/style/StyleBuilderConverter.h#881

https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/rendering/style/TextDecorationThickness.h

Comment 1 Tim Nguyen (:ntim) 2023-10-08 10:36:26 PDT

This should fix this WPT: 

imported/w3c/web-platform-tests/css/css-fonts/size-adjust-text-decoration.tentative.html

Comment 2 ChangSeok Oh 2023-10-12 10:49:41 PDT

I will take a look.

Comment 3 ChangSeok Oh 2023-10-12 10:53:06 PDT

By the way, is the name of size-adjust-text-decoration.tentative.html a mistake? Its reference file name is size-adjust-text-decoration-tentative-ref.html. Yeah, I am talking about the dot just before "tentative".

Comment 4 ChangSeok Oh 2023-10-14 09:36:19 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19085

Comment 5 Radar WebKit Bug Importer 2023-10-15 10:36:13 PDT

<rdar://problem/116985587>

Comment 6 ChangSeok Oh 2023-10-15 17:47:15 PDT

*** Bug 255868 has been marked as a duplicate of this bug. ***

Comment 7 EWS 2023-10-28 04:16:17 PDT

Committed 269886@main (4172b60326a8): <https://commits.webkit.org/269886@main>

Reviewed commits have been landed. Closing PR #19085 and removing active labels.