Bug 262870 - Dead code in MediaPlayerPrivateWebM
Summary: Dead code in MediaPlayerPrivateWebM
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-08 14:31 PDT by Jean-Yves Avenard [:jya]
Modified: 2023-12-06 20:28 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-10-08 14:31:51 PDT 
Code to abort the current demuxing operation can be found in the MediaPlayerPrivateWebM , the code was copied from the SourceBufferPrivateAVFObjC but is not used [1] 

`abort()` is only called in the destructor and so is redundant with simply testing that the weak pointer isn't null.

[1] https://searchfox.org/wubkat/rev/9709f5c78a15a0ae1e723096557a6a060822d868/Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.mm#1140-1144
Comment 1 Radar WebKit Bug Importer 2023-10-08 14:32:05 PDT 
<rdar://problem/116652806>
Comment 2 Jean-Yves Avenard [:jya] 2023-12-06 20:28:53 PST 
Was fixed by bug 264847