Bug 262889 - Optimize Vector::appendRange() when input iterators are random access iterators
Summary: Optimize Vector::appendRange() when input iterators are random access iterators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-09 07:41 PDT by Chris Dumez
Modified: 2023-10-09 15:12 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-10-09 07:41:04 PDT 
Optimize Vector::appendRange() when input iterators are random access iterators. When such iterators are provided, we can compute the new size in constant time and thus reserve capacity + unsafeAppendWithoutCapacityCheck().
Comment 1 Chris Dumez 2023-10-09 07:42:59 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18839
Comment 2 Chris Dumez 2023-10-09 10:26:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18847
Comment 3 EWS 2023-10-09 15:11:17 PDT 
Committed 269115@main (d9dcd1c0fc11): <https://commits.webkit.org/269115@main>

Reviewed commits have been landed. Closing PR #18847 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-10-09 15:12:25 PDT 
<rdar://problem/116702178>