Bug 262891 - WTF::computeHash() with RefPtr/CheckedPtr hashes the result of implicit boolean conversion
Summary: WTF::computeHash() with RefPtr/CheckedPtr hashes the result of implicit boole...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks: 260925
  Show dependency tree / graph
 
Reported: 2023-10-09 08:16 PDT by Antti Koivisto
Modified: 2023-10-09 10:27 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2023-10-09 08:16:44 PDT 
This can result in terrible hashing if the key contains RefPtrs, for example

using ResolverSharingKey = std::tuple<Vector<RefPtr<StyleSheetContents>>, bool, bool>;

in Style::Scope.
Comment 1 Radar WebKit Bug Importer 2023-10-09 08:17:18 PDT 
<rdar://problem/116679372>
Comment 2 Antti Koivisto 2023-10-09 08:21:03 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18842
Comment 3 EWS 2023-10-09 10:27:16 PDT 
Committed 269081@main (a7e29096ee47): <https://commits.webkit.org/269081@main>

Reviewed commits have been landed. Closing PR #18842 and removing active labels.