263007 – [@property] Make validation happen at parse-time

Bug 263007 - [@property] Make validation happen at parse-time

Summary: [@property] Make validation happen at parse-time

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	CSS (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Matthieu Dubet

URL:
Keywords:	GoodFirstBug, InRadar

Depends on:
Blocks:

Reported:	2023-10-11 04:21 PDT by Tim Nguyen (:ntim)
Modified:	2023-10-18 08:25 PDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tim Nguyen (:ntim) 2023-10-11 04:21:02 PDT

See https://github.com/web-platform-tests/interop/issues/575 & https://phabricator.services.mozilla.com/D190444

Comment 1 Radar WebKit Bug Importer 2023-10-11 04:33:23 PDT

<rdar://problem/116803886>

Comment 2 Tim Nguyen (:ntim) 2023-10-11 10:25:54 PDT

It's basically moving the early return checks from https://searchfox.org/wubkat/rev/e21786e1635702a6ca7c1e30290f32e8a97fec23/Source/WebCore/style/CustomPropertyRegistry.cpp#84 to https://searchfox.org/wubkat/rev/e21786e1635702a6ca7c1e30290f32e8a97fec23/Source/WebCore/css/parser/CSSParserImpl.cpp#1028

Comment 3 Matthieu Dubet 2023-10-13 08:54:20 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19050

Comment 4 EWS 2023-10-18 08:25:07 PDT

Committed 269466@main (31ae9755adc7): <https://commits.webkit.org/269466@main>

Reviewed commits have been landed. Closing PR #19050 and removing active labels.