Bug 263051 - return a createCommaSeparated() in CSSPropertyBackgroundBlendMode
Summary: return a createCommaSeparated() in CSSPropertyBackgroundBlendMode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 17
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Karl Dubost
URL:
Keywords: InRadar
Depends on: 263104
Blocks:
  Show dependency tree / graph
 
Reported: 2023-10-11 17:39 PDT by Karl Dubost
Modified: 2023-10-13 15:47 PDT (History)
2 users (show)

See Also:

Attachments
testcase (850 bytes, text/html)
2023-10-11 17:39 PDT, Karl Dubost 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Dubost 2023-10-11 17:39:13 PDT 
Created attachment 468182 [details]
testcase

Currently the CSSPropertyBackgroundBlendMode, returns a space separated list instead of comma separated list

-        return CSSValueList::createSpaceSeparated(WTFMove(list));
+        return CSSValueList::createCommaSeparated(WTFMove(list));


Uploaded Simple Test by Simon Fraser.

It should return: 
   "normal, luminosity"
and not
   "normal luminosity"
Comment 1 Radar WebKit Bug Importer 2023-10-11 17:39:50 PDT 
<rdar://problem/116838342>
Comment 2 Karl Dubost 2023-10-11 17:51:20 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/18971
Comment 4 Karl Dubost 2023-10-11 18:01:13 PDT 
See Bug 261552 (and my new coming comment there) ;)
Comment 5 Ahmad Saleem 2023-10-11 18:02:32 PDT 
(In reply to Karl Dubost from comment #4)
> See Bug 261552 (and my new coming comment there) ;)

Sweet!! :-)
Comment 6 Karl Dubost 2023-10-11 19:42:30 PDT 
Note tests will be fixed/extended in 
https://github.com/web-platform-tests/wpt/issues/42496
Comment 7 EWS 2023-10-13 15:47:51 PDT 
Committed 269325@main (c7bdf3966172): <https://commits.webkit.org/269325@main>

Reviewed commits have been landed. Closing PR #18971 and removing active labels.