Bug 263193 - Build error when CSS_BOX_DECORATION_BREAK is disabled
Summary: Build error when CSS_BOX_DECORATION_BREAK is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-16 06:09 PDT by perry
Modified: 2023-10-17 12:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2023-10-16 06:22 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description perry 2023-10-16 06:09:19 PDT 
There is a build error when CSS_BOX_DECORATION_BREAK is disabled on LineBuilder::candidateContentForLine.
Comment 1 zalan 2023-10-16 06:22:44 PDT 
Created attachment 468228 [details]
Patch
Comment 2 EWS 2023-10-16 08:14:46 PDT 
Committed 269362@main (f2560fbccb1a): <https://commits.webkit.org/269362@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468228 [details].
Comment 3 Radar WebKit Bug Importer 2023-10-16 08:15:15 PDT 
<rdar://problem/117018650>
Comment 4 perry 2023-10-17 05:42:01 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/19162
Comment 5 Simon Fraser (smfr) 2023-10-17 12:20:01 PDT 
CSS_BOX_DECORATION_BREAK has been enabled for 10 years. Why are you building with it turned off? Can we just remove it?