Bug 263249 - safe-merge-queue should gracefully handle network failures with github
Summary: safe-merge-queue should gracefully handle network failures with github
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brianna Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-17 08:26 PDT by Aakash Jain
Modified: 2023-10-19 10:54 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2023-10-17 08:26:02 PDT 
safe-merge-queue should gracefully handle network failures with github..

In https://ews-build.webkit.org/#/builders/40/builds/653 it failed with an exception. 

Failed to connect to https://api.github.com

  File "/var/buildbot/OpenSource/Tools/CISupport/ews-build/steps.py", line 236, in query_graph_ql
    data = json.loads(response.text)
builtins.AttributeError: 'NoneType' object has no attribute 'text'
Comment 1 Radar WebKit Bug Importer 2023-10-18 16:42:00 PDT 
<rdar://problem/117172642>
Comment 2 Brianna Fan 2023-10-18 16:52:19 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19257
Comment 3 EWS 2023-10-19 10:54:29 PDT 
Committed 269534@main (c73420e62f40): <https://commits.webkit.org/269534@main>

Reviewed commits have been landed. Closing PR #19257 and removing active labels.