Bug 263272 - Drop redundant check in SkipOptionalSVGSpacesOrDelimiter
Summary: Drop redundant check in SkipOptionalSVGSpacesOrDelimiter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-17 12:34 PDT by Ahmad Saleem
Modified: 2023-10-18 11:19 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-10-17 12:34:24 PDT 
Hi Team,

This is just potential merge of following Blink commit:

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/2642784

WebKit Source: https://github.com/WebKit/WebKit/blob/6eedbb94b3dea4ce23f51563eb49a4a7c5344463/Source/WebCore/svg/SVGParserUtilities.h#L101

It is to remove following check:

if (characters.hasCharactersRemaining() && *characters == delimiter) {

to

if (*characters == delimiter) {

___

Just wanted to raise so we can merge as well.

Thanks!
Comment 1 EWS 2023-10-18 11:18:31 PDT 
Committed 269478@main (56bcdb9d3730): <https://commits.webkit.org/269478@main>

Reviewed commits have been landed. Closing PR #19180 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-10-18 11:19:15 PDT 
<rdar://problem/117147899>