Bug 263275 - RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateActivityState doesn't dispatch didRefreshDisplay if it tries to wait for a second commitLayerTree message
Summary: RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateActivityState doesn't dispat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-17 13:09 PDT by Matt Woodrow
Modified: 2023-10-18 13:56 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-10-17 13:09:12 PDT 
<rdar://113318934>

waitForDidUpdateActivityState sends a didRefreshDisplay message to the web content process (if one was pending) to ensure that the web process knows it can commit a new layer tree.

If the incoming CommitLayerTree message didn't include the right activity state change, then we wait again, but don't send a new didRefreshDisplay, and we wait for a message that isn't coming.
Comment 1 Matt Woodrow 2023-10-17 13:10:56 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19182
Comment 2 EWS 2023-10-18 13:56:43 PDT 
Committed 269486@main (ee5c4b70a09c): <https://commits.webkit.org/269486@main>

Reviewed commits have been landed. Closing PR #19182 and removing active labels.