Bug 263324 - [JSC][armv7] Reserve `d14` for scratch use in JITs
Summary: [JSC][armv7] Reserve `d14` for scratch use in JITs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-18 10:20 PDT by Joseph Griego
Modified: 2023-10-25 08:22 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Griego 2023-10-18 10:20:30 PDT 
We really desperately need an extra scratch FP register for ARMv7 BBQ--steal `d14` for this purpose, in exactly the same way as `d15` is reserved for the macro assembler--though this register is callee-save in the platform ABI, it's saved and restored at VM entry/exit, so we can hijack it.
Comment 1 Joseph Griego 2023-10-18 10:24:36 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19234
Comment 2 EWS 2023-10-25 08:21:44 PDT 
Committed 269762@main (1ff6d45f35c1): <https://commits.webkit.org/269762@main>

Reviewed commits have been landed. Closing PR #19234 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-10-25 08:22:15 PDT 
<rdar://problem/117475969>