Bug 263362 - Fix break with LAYER_BASED_SVG_ENGINE disabled after 269492@main
Summary: Fix break with LAYER_BASED_SVG_ENGINE disabled after 269492@main
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yousuke Kimoto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-18 22:25 PDT by Yousuke Kimoto
Modified: 2023-10-19 02:57 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuke Kimoto 2023-10-18 22:25:29 PDT 
When LAYER_BASED_SVG_ENGINE is disabled, RenderSVGShape is used in SVGRenderSupport.cpp and the class is defined LAYER_BASED_SVG_ENGINE enabled.
Also an inline error occurs:

  Source\WebCore\rendering\svg\legacy\LegacyRenderSVGShape.h(102,17): error : inline function 'WebCore::LegacyRenderSVGShape::hasNonScalingStroke' is not defined [-Werror,-Wundefined-inline]

To solve the build break, it needs to add some conditional codes and include LegacyRenderSVGShapeInlines.h in SVGRenderSupport.cpp.
Comment 1 Yousuke Kimoto 2023-10-18 22:56:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19272
Comment 2 EWS 2023-10-19 02:56:07 PDT 
Committed 269511@main (b2f96217de84): <https://commits.webkit.org/269511@main>

Reviewed commits have been landed. Closing PR #19272 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-10-19 02:57:18 PDT 
<rdar://problem/117195926>