Bug 263487 - AX: Soft-link UIAccessibility constants rather than duplicating them in iOS AX
Summary: AX: Soft-link UIAccessibility constants rather than duplicating them in iOS AX
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-20 17:52 PDT by Tyler Wilcock
Modified: 2023-10-21 10:31 PDT (History)
10 users (show)

See Also:

Attachments
Patch (11.00 KB, patch)
2023-10-20 17:59 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (12.15 KB, patch)
2023-10-20 19:20 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2023-10-20 17:52:11 PDT 
Duplicating them can cause conflicts when we try to link the framework they're defined in.
Comment 1 Radar WebKit Bug Importer 2023-10-20 17:52:19 PDT 
<rdar://problem/117287269>
Comment 2 Tyler Wilcock 2023-10-20 17:59:01 PDT 
Created attachment 468289 [details]
Patch
Comment 3 chris fleizach 2023-10-20 18:16:41 PDT 
Comment on attachment 468289 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468289&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:35
> +// FIXME: Does any AT actually consume this attributed string token?

which one? heading level?

VO should consume it
Comment 4 Tyler Wilcock 2023-10-20 19:20:00 PDT 
Created attachment 468291 [details]
Patch
Comment 5 EWS 2023-10-21 10:31:50 PDT 
Committed 269627@main (a96bfc4f0175): <https://commits.webkit.org/269627@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468291 [details].