Bug 263532 - [MSE][GStreamer] always reset appsink/parser state when recycling the track
Summary: [MSE][GStreamer] always reset appsink/parser state when recycling the track
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-23 10:18 PDT by Enrique Ocaña
Modified: 2023-10-25 08:01 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2023-10-23 10:18:56 PDT 
After applying [1], appsink can receive EOS event that was sent by qtdemux before removing an "old" streamd. This marks the sink as "received_eos" and makes it reject any events from subsequent appends. Resulting in append failing with ParsingFailed error.

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1208

[1] https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4535
Comment 1 Enrique Ocaña 2023-10-23 10:24:46 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19424
Comment 2 EWS 2023-10-25 08:00:37 PDT 
Committed 269761@main (8842c1ea3c56): <https://commits.webkit.org/269761@main>

Reviewed commits have been landed. Closing PR #19424 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-10-25 08:01:14 PDT 
<rdar://problem/117475086>