Bug 263578 - Rename webrtc::pixelBufferFrom* functions to have 'create' in the name and fix a CVPixelBufferRef leak
Summary: Rename webrtc::pixelBufferFrom* functions to have 'create' in the name and fi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-23 20:33 PDT by Simon Fraser (smfr)
Modified: 2023-10-24 20:12 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2023-10-23 20:33:56 PDT 
These functions return retained values, so should have 'create' in the name:

CVPixelBufferRef pixelBufferFromI420Buffer(const uint8_t* buffer, size_t length, size_t width, size_t height, I420BufferLayout) CF_RETURNS_RETAINED;
CVPixelBufferRef pixelBufferFromI420ABuffer(const uint8_t* buffer, size_t length, size_t width, size_t height, I420ABufferLayout) CF_RETURNS_RETAINED;
Comment 1 Radar WebKit Bug Importer 2023-10-23 20:34:15 PDT 
<rdar://problem/117388614>
Comment 2 Simon Fraser (smfr) 2023-10-23 20:35:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19471
Comment 3 EWS 2023-10-24 20:12:42 PDT 
Committed 269747@main (11a2ba1a7a1c): <https://commits.webkit.org/269747@main>

Reviewed commits have been landed. Closing PR #19471 and removing active labels.