Bug 263648 - WebGLRenderingContextBase::m_needsUpdate is a redundant flag
Summary: WebGLRenderingContextBase::m_needsUpdate is a redundant flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 263770
  Show dependency tree / graph
 
Reported: 2023-10-25 05:32 PDT by Kimmo Kinnunen
Modified: 2023-10-27 04:17 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2023-10-25 05:32:35 PDT 
WebGLRenderingContextBase::m_needsUpdate is a redundant flag

It is only set once per context creation and it controls the invalidation that is always made anyway.
Comment 1 Radar WebKit Bug Importer 2023-10-25 05:32:47 PDT 
<rdar://problem/117469562>
Comment 2 Kimmo Kinnunen 2023-10-25 05:56:38 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19531
Comment 3 EWS 2023-10-26 23:20:09 PDT 
Committed 269841@main (7b16f53a6ca3): <https://commits.webkit.org/269841@main>

Reviewed commits have been landed. Closing PR #19531 and removing active labels.