Bug 263653 - [webkitscmpy] Caller must provide arguments to remote files_changed
Summary: [webkitscmpy] Caller must provide arguments to remote files_changed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks: 261242
  Show dependency treegraph
 
Reported: 2023-10-25 07:15 PDT by Jonathan Bedard
Modified: 2023-10-25 09:46 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-10-25 07:15:50 PDT
For a local repository, it makes sense for 'files_changed' to be an optional argument (because we can assume that if no git ref is provided, the caller means "files changed in the current checkout" as opposed to "files changed in a specific commit". That logic doesn't apply to a remote repository, where we should raise a ValueError if a caller requests files_changed without specifying some sort of git ref.
Comment 1 Radar WebKit Bug Importer 2023-10-25 07:16:02 PDT
<rdar://problem/117473288>
Comment 2 Jonathan Bedard 2023-10-25 07:19:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19536
Comment 3 EWS 2023-10-25 09:46:42 PDT
Committed 269765@main (3e615409768a): <https://commits.webkit.org/269765@main>

Reviewed commits have been landed. Closing PR #19536 and removing active labels.