Bug 263673 - `import-w3c-tests -t web-platform-tests/html/canvas/tools/templates` -> `ValueError: Malformed fuzzy value "{{ fuzzy }}"`
Summary: `import-w3c-tests -t web-platform-tests/html/canvas/tools/templates` -> `Valu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-25 10:45 PDT by Sam Sneddon [:gsnedders]
Modified: 2024-06-24 13:59 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2023-10-25 10:45:48 PDT
rdar://115101277

Summary:
`import-w3c-tests -t web-platform-tests/html/canvas/tools/templates` crashes with `ValueError: Malformed fuzzy value "{{ fuzzy }}"`

Steps To Reproduce:
1. In a terminal, go to a clean WebKit repo.
2. Run `import-w3c-tests -t web-platform-tests/html/canvas/tools/templates`.

Results:
```
Downloading W3C test repositories
Fetching https://github.com/web-platform-tests/wpt.git...
Checking out revision origin/master
Scanning /Volumes/WebKit/OpenSource/WebKitBuild/w3c-tests/web-platform-tests/html/canvas/tools/templates/...
Traceback (most recent call last):
  File "/Volumes/WebKit/OpenSource/Tools/Scripts/import-w3c-tests", line 35, in <module>
    sys.exit(test_importer.main(sys.argv[1:], sys.stdout, sys.stderr))
  File "/Volumes/WebKit/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 101, in main
    test_importer.do_import()
  File "/Volumes/WebKit/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 227, in do_import
    self.find_importable_tests(self.filesystem.join(self.source_directory, test_path))
  File "/Volumes/WebKit/OpenSource/Tools/Scripts/webkitpy/w3c/test_importer.py", line 350, in find_importable_tests
    test_info = test_parser.analyze_test()
  File "/Volumes/WebKit/OpenSource/Tools/Scripts/webkitpy/w3c/test_parser.py", line 149, in analyze_test
    test_info['fuzzy'] = self.fuzzy_metadata()
  File "/Volumes/WebKit/OpenSource/Tools/Scripts/webkitpy/w3c/test_parser.py", line 217, in fuzzy_metadata
    raise ValueError("Malformed fuzzy value \"%s\"" % fuzzy_data)
ValueError: Malformed fuzzy value "{{ fuzzy }}"
```

Tested at c734176258bc aka 267716@main, while WPT was at https://github.com/web-platform-tests/wpt/commit/d1f3f8d5a1c9f22ce5157867b37ca53cb613dbc0 .
Comment 1 Sam Sneddon [:gsnedders] 2023-10-25 11:06:39 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19554
Comment 2 Sam Sneddon [:gsnedders] 2023-11-16 08:03:13 PST
Pull request: https://github.com/WebKit/WebKit/pull/20610
Comment 3 EWS 2023-11-17 03:14:07 PST
Committed 270878@main (71c0ce6cf2ce): <https://commits.webkit.org/270878@main>

Reviewed commits have been landed. Closing PR #20610 and removing active labels.
Comment 4 EWS 2024-04-18 07:57:24 PDT
Committed 277673@main (b70287103be9): <https://commits.webkit.org/277673@main>

Reviewed commits have been landed. Closing PR #19554 and removing active labels.