<rdar://problem/117530301>

Created attachment 468351 [details]
Patch

Comment on attachment 468351 [details]
Patch

Looks good, but failing GTK + WPE bots

Created attachment 468361 [details]
Patch

Follow up fix for ATSPI.

I'll check the atspi failure as soon as I find some time.

Created attachment 468469 [details]
Patch

Comment on attachment 468469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468469&action=review

> LayoutTests/platform/glib/TestExpectations:460
> +accessibility/focus-inside-modal.html

Do we have have to specify [ Skip ] or [ Timeout ]?

Created attachment 468474 [details]
Patch

(In reply to Tyler Wilcock from comment #7)
> Comment on attachment 468469 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=468469&action=review
> 
> > LayoutTests/platform/glib/TestExpectations:460
> > +accessibility/focus-inside-modal.html
> 
> Do we have have to specify [ Skip ] or [ Timeout ]?

Yes! hadn't had enough coffee this morning, thanks!

Comment on attachment 468474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=468474&action=review

> COMMIT_MESSAGE:15
> +In addition the following ATSPI fix is needed for the test to pass in this platform (follow up to https://bugs.webkit.org/show_bug.cgi?id=263678):
> +* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp:
> +(WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):

I'm confused, this change is needed to make it pass, but you are also skipping it saying it times out.

I'm sorry I haven't been able to look at this yet, it's been a busy week. I'm fine to land this with the test marked as failure to not block you.

(In reply to Carlos Garcia Campos from comment #10)
> Comment on attachment 468474 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=468474&action=review
> 
> > COMMIT_MESSAGE:15
> > +In addition the following ATSPI fix is needed for the test to pass in this platform (follow up to https://bugs.webkit.org/show_bug.cgi?id=263678):
> > +* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp:
> > +(WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
> 
> I'm confused, this change is needed to make it pass, but you are also
> skipping it saying it times out.
Andres, do you know if the test is passing after making this change, meaning we don't need to mark it as skip / timeout?

Committed 270272@main (3de34e00862a): <https://commits.webkit.org/270272@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468474 [details].

(In reply to Carlos Garcia Campos from comment #10)
> Comment on attachment 468474 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=468474&action=review
> 
> > COMMIT_MESSAGE:15
> > +In addition the following ATSPI fix is needed for the test to pass in this platform (follow up to https://bugs.webkit.org/show_bug.cgi?id=263678):
> > +* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityNotificationHandler.cpp:
> > +(WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
> 
> I'm confused, this change is needed to make it pass, but you are also
> skipping it saying it times out.

I believe that change is necessary as it is in COCOA, but it wasn't sufficient for ATSPI, still failing after that change. That's why I marked it as skip.