Bug 263757 - [macOS MiniBrowser] Implement pointer lock client delegates and display banner
Summary: [macOS MiniBrowser] Implement pointer lock client delegates and display banner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Abrar Rahman Protyasha
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-26 18:36 PDT by Abrar Rahman Protyasha
Modified: 2023-10-27 09:52 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abrar Rahman Protyasha 2023-10-26 18:36:13 PDT 
Right now, MiniBrowser does not support pointer lock since it doesn't provide an implementation for the `_webViewDidRequestPointerLock` client delegate. We should implement this and the `_webViewDidLosePointerLock` in a way that displays a banner informing the user about their pointer (and how to exit out of the pointer lock state), such that MiniBrowser will support pointer lock.
Comment 1 Radar WebKit Bug Importer 2023-10-26 18:37:37 PDT 
<rdar://problem/117562146>
Comment 2 Abrar Rahman Protyasha 2023-10-26 18:43:12 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19617
Comment 3 EWS 2023-10-27 09:52:25 PDT 
Committed 269854@main (8ce6e671f9d0): <https://commits.webkit.org/269854@main>

Reviewed commits have been landed. Closing PR #19617 and removing active labels.