Bug 263832 - AX: 17 AccessibilityRole variants never constructed, making them effectively dead code
Summary: AX: 17 AccessibilityRole variants never constructed, making them effectively ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-28 13:21 PDT by Tyler Wilcock
Modified: 2023-10-28 18:15 PDT (History)
10 users (show)

See Also:

Attachments
Patch (23.45 KB, patch)
2023-10-28 13:26 PDT, Tyler Wilcock 		cfleizach: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (23.88 KB, patch)
2023-10-28 13:31 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (23.88 KB, patch)
2023-10-28 13:34 PDT, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2023-10-28 13:21:48 PDT 
This hurts compile times and also hurts performance, as the compiler must generate branches for these roles that will never actually be taken.
Comment 1 Radar WebKit Bug Importer 2023-10-28 13:21:56 PDT 
<rdar://problem/117631943>
Comment 2 Tyler Wilcock 2023-10-28 13:26:00 PDT 
Created attachment 468383 [details]
Patch
Comment 3 Tyler Wilcock 2023-10-28 13:31:06 PDT 
Created attachment 468384 [details]
Patch
Comment 4 Tyler Wilcock 2023-10-28 13:34:25 PDT 
Created attachment 468385 [details]
Patch
Comment 5 EWS 2023-10-28 18:15:56 PDT 
Committed 269898@main (f304f766b590): <https://commits.webkit.org/269898@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468385 [details].