We use the name attribute for the AXRadioGroupSearchKey, which allows clients to find the next / previous distinct radiogroup. By not updating AXPropertyName::NameAttribute, this search query can return incorrect results after dynamic changes.
<rdar://problem/117641685>
Created attachment 468396 [details] Patch
Comment on attachment 468396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=468396&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:592 > + else Does storing an empty string recreate the issue we tried to fix by not storing default values?
Created attachment 468401 [details] Patch
(In reply to chris fleizach from comment #3) > Comment on attachment 468396 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=468396&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:592 > > + else > > Does storing an empty string recreate the issue we tried to fix by not > storing default values? Uploaded a new version of the patch that removes std::optional from the method signature of nameAttribute(), obviating the need to store an empty string here (which would've resulted in AXPropertyName::NameAttribute from being removed from the map rather than storing an empty string per AXIsolatedObject::setProperty).
Committed 269912@main (2ab054fd990f): <https://commits.webkit.org/269912@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468401 [details].