Bug 263891 - Fix warnings from webrtc::RtpSenderInterface when linking libwebrtc.dylib
Summary: Fix warnings from webrtc::RtpSenderInterface when linking libwebrtc.dylib
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-30 09:28 PDT by David Kilzer (:ddkilzer)
Modified: 2023-10-30 10:19 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-10-30 09:28:56 PDT 
Fix warnings when linking libwebrtc.dylib in webrtc::RtpSenderInterface:

ld: warning: cannot export hidden symbol webrtc::RtpSenderInterface::dtls_transport() const from libwebrtc.build/Release/libwebrtc.build/Objects-normal/arm64e/rtp_sender_interface.o
ld: warning: cannot export hidden symbol webrtc::RtpSenderInterface::init_send_encodings() const from libwebrtc.build/Release/libwebrtc.build/Objects-normal/arm64e/rtp_sender_interface.o
ld: warning: cannot export hidden symbol webrtc::RtpSenderInterface::SetFrameEncryptor(rtc::scoped_refptr<webrtc::FrameEncryptorInterface>) from libwebrtc.build/Release/libwebrtc.build/Objects-normal/arm64e/rtp_sender_interface.o
ld: warning: cannot export hidden symbol webrtc::RtpSenderInterface::GetFrameEncryptor() const from libwebrtc.build/Release/libwebrtc.build/Objects-normal/arm64e/rtp_sender_interface.o
ld: warning: cannot export hidden symbol webrtc::RtpSenderInterface::SetEncoderToPacketizerFrameTransformer(rtc::scoped_refptr<webrtc::FrameTransformerInterface>) from libwebrtc.build/Release/libwebrtc.build/Objects-normal/arm64e/rtp_sender_interface.o
Comment 1 Radar WebKit Bug Importer 2023-10-30 09:29:13 PDT 
<rdar://problem/117690391>
Comment 2 David Kilzer (:ddkilzer) 2023-10-30 09:43:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19722
Comment 3 EWS 2023-10-30 10:19:01 PDT 
Committed 269954@main (55303b3ac53b): <https://commits.webkit.org/269954@main>

Reviewed commits have been landed. Closing PR #19722 and removing active labels.