Bug 263892 - REGRESSION(267944@main): wpt /css/CSS2/positioning/abspos-block-level-001.html
Summary: REGRESSION(267944@main): wpt /css/CSS2/positioning/abspos-block-level-001.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-30 09:30 PDT by Sam Sneddon [:gsnedders]
Modified: 2023-11-01 11:56 PDT (History)
5 users (show)

See Also:

Attachments
test reduction (100 bytes, text/html)
2023-10-30 13:42 PDT, zalan 		no flags Details
Patch (10.04 KB, patch)
2023-10-31 13:16 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.04 KB, patch)
2023-10-31 14:22 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.31 KB, patch)
2023-10-31 16:26 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.39 KB, patch)
2023-10-31 20:51 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (12.39 KB, patch)
2023-11-01 06:55 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2023-10-30 09:30:44 PDT 
<rdar://problem/117690490>
Comment 2 zalan 2023-10-30 13:42:24 PDT 
Created attachment 468416 [details]
test reduction

it looks like trimmed trailing whitespace confuses out-of-flow static position logic.
Comment 3 zalan 2023-10-30 20:49:27 PDT 
2 issues:
- out-of-flow boxes has to be passed in as objectReplacementCharacter (and not as truly opaque items) to icu (InlineItemsBuilder::buildBidiParagraph)
- right to left inline direction (has nothing to do with bidi) needs "visually backwards" search when looking for "before" in-flow content to decide where (display: block) out-of-flow box should go (InlineDisplayContentBuilder::setGeometryForBlockLevelOutOfFlowBoxes)
(have a local fix, will upload a patch tomorrow)
Comment 4 zalan 2023-10-31 13:16:32 PDT 
Created attachment 468432 [details]
Patch
Comment 5 zalan 2023-10-31 13:17:34 PDT 
(In reply to zalan from comment #2)
> Created attachment 468416 [details]
> test reduction
> 
> it looks like trimmed trailing whitespace confuses out-of-flow static
> position logic.
270022@main has addressed it.
Comment 6 zalan 2023-10-31 14:22:52 PDT 
Created attachment 468434 [details]
Patch
Comment 7 zalan 2023-10-31 16:26:58 PDT 
Created attachment 468436 [details]
Patch
Comment 8 zalan 2023-10-31 20:51:55 PDT 
Created attachment 468438 [details]
Patch
Comment 9 zalan 2023-11-01 06:55:11 PDT 
Created attachment 468442 [details]
[fast-cq]Patch
Comment 10 EWS 2023-11-01 11:56:51 PDT 
Committed 270069@main (f1664d74b5e3): <https://commits.webkit.org/270069@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 468442 [details].