Bug 263905 - build-webkit --minimal option has bitrotted
Summary: build-webkit --minimal option has bitrotted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-30 10:54 PDT by Philip Chimento
Modified: 2023-11-02 00:29 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Chimento 2023-10-30 10:54:29 PDT
I tried building a recent checkout with `build-webkit --gtk --minimal --notifications --service-worker`, and encountered a bunch of compile and link errors due to missing preprocessor guards, or headers needed in one file that were pulled in through another file behind a preprocessor guard. I've prepared a PR with fixes for these errors, that should get --minimal close to working again, at least for the GTK port.
Comment 1 Philip Chimento 2023-10-30 12:14:33 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19732
Comment 2 EWS 2023-11-02 00:28:12 PDT
Committed 270103@main (cfc4a23cc201): <https://commits.webkit.org/270103@main>

Reviewed commits have been landed. Closing PR #19732 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-11-02 00:29:16 PDT
<rdar://problem/117837817>