RESOLVED FIXED263938
[Xcode] Dead webkitdirs.pm code assumes all signing identities start with "iPhone Developer" 
https://bugs.webkit.org/show_bug.cgi?id=263938
Summary [Xcode] Dead webkitdirs.pm code assumes all signing identities start with "iP...
Elliott Williams
Reported 2023-10-30 16:46:17 PDT
They have been called "Apple Developer" for years now, so the fact that we've never been asked to fix this makes me think the logic is not needed.
Attachments
Add attachment proposed patch, testcase, etc.
Elliott Williams
Comment 1 2023-10-30 16:46:25 PDT
<rdar://problem/96538743>
Elliott Williams
Comment 2 2023-10-30 16:51:10 PDT
Pull request: https://github.com/WebKit/WebKit/pull/19748
EWS
Comment 3 2023-11-01 12:43:26 PDT
Committed 270072@main (3ad1996f37dc): <https://commits.webkit.org/270072@main> Reviewed commits have been landed. Closing PR #19748 and removing active labels.
Elliott Williams
Comment 4 2023-11-02 14:50:54 PDT
Reverting, this broke the internal iOS build.
EWS
Comment 5 2023-11-02 14:55:07 PDT
Committed 270144@main (ab752d94dae2): <https://commits.webkit.org/270144@main> Reviewed commits have been landed. Closing PR #19908 and removing active labels.
Elliott Williams
Comment 6 2023-11-02 16:50:05 PDT
Re-opening for pull request https://github.com/WebKit/WebKit/pull/19915
EWS
Comment 7 2023-11-03 05:58:33 PDT
Committed 270170@main (7c98ddb04211): <https://commits.webkit.org/270170@main> Reviewed commits have been landed. Closing PR #19915 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.