Bug 263938 - [Xcode] Dead webkitdirs.pm code assumes all signing identities start with "iPhone Developer"
Summary: [Xcode] Dead webkitdirs.pm code assumes all signing identities start with "iP...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-30 16:46 PDT by Elliott Williams
Modified: 2023-11-03 05:58 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2023-10-30 16:46:17 PDT 
They have been called "Apple Developer" for years now, so the fact that we've never been asked to fix this makes me think the logic is not needed.
Comment 1 Elliott Williams 2023-10-30 16:46:25 PDT 
<rdar://problem/96538743>
Comment 2 Elliott Williams 2023-10-30 16:51:10 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19748
Comment 3 EWS 2023-11-01 12:43:26 PDT 
Committed 270072@main (3ad1996f37dc): <https://commits.webkit.org/270072@main>

Reviewed commits have been landed. Closing PR #19748 and removing active labels.
Comment 4 Elliott Williams 2023-11-02 14:50:54 PDT 
Reverting, this broke the internal iOS build.
Comment 5 EWS 2023-11-02 14:55:07 PDT 
Committed 270144@main (ab752d94dae2): <https://commits.webkit.org/270144@main>

Reviewed commits have been landed. Closing PR #19908 and removing active labels.
Comment 6 Elliott Williams 2023-11-02 16:50:05 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/19915
Comment 7 EWS 2023-11-03 05:58:33 PDT 
Committed 270170@main (7c98ddb04211): <https://commits.webkit.org/270170@main>

Reviewed commits have been landed. Closing PR #19915 and removing active labels.