263960 – [CSSOM] Stylesheet::insertRule shoud return index on successful insertion

Bug 263960 - [CSSOM] Stylesheet::insertRule shoud return index on successful insertion

Summary: [CSSOM] Stylesheet::insertRule shoud return index on successful insertion

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	WebCore Misc. (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2023-10-31 02:36 PDT by Matthieu Dubet
Modified:	2023-10-31 02:44 PDT (History)
CC List:	1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Matthieu Dubet 2023-10-31 02:36:32 PDT

https://drafts.csswg.org/cssom/#insert-a-css-rule

Step 8 : Return index.

We return a constant -1 for historical reason, time to respect the spec

Comment 1 Radar WebKit Bug Importer 2023-10-31 02:36:51 PDT

<rdar://problem/117730318>

Comment 2 Matthieu Dubet 2023-10-31 02:44:45 PDT

It's already the case 

https://github.com/WebKit/WebKit/blob/399d66f88e336da795cf2ed2836dee80af046b19/Source/WebCore/css/CSSStyleSheet.cpp#L367


And addRule returns -1 per spec

https://drafts.csswg.org/cssom/#insert-a-css-rule:~:text=index%20as%20arguments.-,Return%20%2D1.,-Authors%20should%20not