Bug 263994 - mModeFlags uses a signed variable instead of unsigned for bits even though mModeFlags is a UInt64
Summary: mModeFlags uses a signed variable instead of unsigned for bits even though mM...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-31 13:45 PDT by Seija K.
Modified: 2024-01-22 07:29 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seija K. 2023-10-31 13:45:26 PDT 
The value we use to bitwise AND should be unsigned or else we risk overflowing an integer and sign extending 1.
Comment 1 Radar WebKit Bug Importer 2023-11-07 12:46:14 PST 
<rdar://problem/118074166>
Comment 2 Ahmad Saleem 2024-01-22 06:48:12 PST 
PR - https://github.com/WebKit/WebKit/pull/19791
Comment 3 EWS 2024-01-22 07:29:44 PST 
Committed 273298@main (bb40425085b9): <https://commits.webkit.org/273298@main>

Reviewed commits have been landed. Closing PR #19791 and removing active labels.