Bug 264013 - [style-checker] test/expectations errors surfaced twice
Summary: [style-checker] test/expectations errors surfaced twice
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-10-31 16:30 PDT by Abrar Rahman Protyasha
Modified: 2023-10-31 16:31 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abrar Rahman Protyasha 2023-10-31 16:30:28 PDT 
The style checker invokes TestExpectation errors twice for me. It's not a serious bug, but does add some noise! Here's a sample of what it looks like:

```
% git webkit pr --no-rebase --no-commit
ERROR: Tools/TestRunnerShared/WPTFunctions.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/TestRunnerShared/WPTFunctions.h:38:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Tools/WebKitTestRunner/mac/TestControllerMac.mm:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:601:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:602:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:603:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:604:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:605:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:606:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:607:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:608:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:601:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:602:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:603:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:604:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:605:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:606:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:607:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
ERROR: /Users/aprotyas/dev/safari/OpenSource/LayoutTests/platform/mac-wk2/TestExpectations:608:  Unrecognized expectation "ImageonlyFailure"  [test/expectations] [5]
```

Notice how the errors in the `[test/expectations]` category are duplicated, once with a relative path from the repository root, and once with an absolute path.
Comment 1 Radar WebKit Bug Importer 2023-10-31 16:31:40 PDT 
<rdar://problem/117769978>