Bug 264104 - [CSS Highlight API] Fix serialization for CSS highlight pseudo-elements
Summary: [CSS Highlight API] Fix serialization for CSS highlight pseudo-elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-02 11:29 PDT by Tim Nguyen (:ntim)
Modified: 2023-11-02 15:20 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2023-11-02 11:29:23 PDT 
<rdar://problem/117864974>
Comment 2 Tim Nguyen (:ntim) 2023-11-02 11:33:57 PDT 
Highlight pseudos need a special case here similar to ::part(): https://searchfox.org/wubkat/rev/67be1e0883407c894c71a4c903e5030059a7b5e9/Source/WebCore/css/CSSSelector.cpp#738-749

This way ::highlight(foo) serializes as such instead of serializing to ::highlight
Comment 3 Tim Nguyen (:ntim) 2023-11-02 11:50:33 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19900
Comment 4 EWS 2023-11-02 15:20:01 PDT 
Committed 270146@main (b63317aba187): <https://commits.webkit.org/270146@main>

Reviewed commits have been landed. Closing PR #19900 and removing active labels.