Bug 264108 - [Xcode] Stop passing -fvisibility-inlines-hidden to TAPI
Summary: [Xcode] Stop passing -fvisibility-inlines-hidden to TAPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-02 12:00 PDT by Elliott Williams
Modified: 2023-11-02 15:24 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2023-11-02 12:00:43 PDT 
It is unrecognized in new builds. We still need to enforce our c++ dialect on TAPI's parser, so we may need to find another way to pass this, if -fvisibility=none is not enough.
Comment 1 Elliott Williams 2023-11-02 12:00:52 PDT 
<rdar://problem/116350284>
Comment 2 Elliott Williams 2023-11-02 13:46:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19905
Comment 3 EWS 2023-11-02 15:24:19 PDT 
Committed 270147@main (27372a0ce8a5): <https://commits.webkit.org/270147@main>

Reviewed commits have been landed. Closing PR #19905 and removing active labels.