Bug 264130 - GlyphData.isValid() audit
Summary: GlyphData.isValid() audit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: Safari 17
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-11-02 20:11 PDT by fantasai
Modified: 2023-11-06 16:47 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description fantasai 2023-11-02 20:11:29 PDT 
I'm reviewing some code and noticed that some places use GlyphData.isValid() and other places use GlyphData.glyph and other places use GlyphData.font to check whether the GlyphData is valid or not.

We should probably be consistent, and probably use .isValid().

See https://github.com/WebKit/WebKit/commit/4535075b56fdb33a076f51fe92cd0bb8832797c8 and https://github.com/WebKit/WebKit/commit/ac25c7819037b1df2d448fca20dbfba7f96ca69c
Comment 1 Radar WebKit Bug Importer 2023-11-03 07:50:39 PDT 
<rdar://problem/117905809>
Comment 2 EWS 2023-11-06 16:47:06 PST 
Committed 270299@main (ef2295446d89): <https://commits.webkit.org/270299@main>

Reviewed commits have been landed. Closing PR #20006 and removing active labels.