Bug 264142 - Move duplicated methods from MediaSourcePrivate/SourceBufferPrivate to base class
Summary: Move duplicated methods from MediaSourcePrivate/SourceBufferPrivate to base c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks: 264134
  Show dependency tree / graph
 
Reported: 2023-11-02 23:40 PDT by Jean-Yves Avenard [:jya]
Modified: 2023-11-07 14:52 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-11-02 23:40:24 PDT 
sub-task of bug 264134

We have three MSE implementations in our tree:
- Cocoa/AVFObjC
- Mock
- GStreamer

In a lot of instances, all three duplicates the same code. It makes it harder to maintain and too easy to introduce discrepancy between the three implementations.

Let's move to their respective base classes what can be moved.
Comment 1 Radar WebKit Bug Importer 2023-11-02 23:40:58 PDT 
<rdar://problem/117892834>
Comment 2 Jean-Yves Avenard [:jya] 2023-11-02 23:48:52 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19937
Comment 3 EWS 2023-11-07 14:52:10 PST 
Committed 270354@main (e25a76a60507): <https://commits.webkit.org/270354@main>

Reviewed commits have been landed. Closing PR #19937 and removing active labels.